-
Notifications
You must be signed in to change notification settings - Fork 114
Fix MultiEvent Catch in Zeppelin #322
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Ready to Merge, I checked all events and made sure they were using the right $scope or $rootScope |
|
Oh, man it was really annoying. Thanks for fix it! |
|
I guess it fix the #206 |
|
Awesome! |
|
I tested this PR and it fixes the multi event catch problem. |
|
Can you give an example so that I can reproduce? I don't really understand what you mean by updating output and progress. I tried in multi browser and it was working well |
|
@corneadoug Can you run any paragraph and see is there any output and progress information updated? |
|
@Leemoonsoo you were right, one change was missing. It is fixed now. |
|
Tested and looks good to me! Cool! |
|
Nice improvement! |
Fix MultiEvent Catch in Zeppelin
Fixing MultiEvent Listener in Zeppelin
There was an annoying bug in zeppelin:
After moving from one note to another, Running the whole note, or adding new paragraph in a note would be done X times.
There is a simple reason related to angularJs: We have overused $rootScope.$on.
When a $rootScope.$on (Event Listener) is registered, it is registered with the $rootScope. Which means that even if the Controller was flushed after a changing page, the $rootScope is not destroy and the event listener is still register for the old Controller.
How to Use Events in AngularJS/Zeppelin
Current ControllerStructure